Jydett comments

Repositories
Issues
Comments

Results 4 comments of


                                            Jydett

fix: parser removing more than generics

I'll switch this PR to draft as I discovered some a new edge case that will be hard to fix: ``` public static void main(String[] args) { int a =...

fix: parser removing more than generics

@meiMingle Hi, i don't think so. If you want to check you can copy [the test class](https://github.com/Col-E/Recaf/pull/746/files#diff-4c558610d76d6de15e1e04b48b9cb3143d30c95e7d11f9b15736a4c99883e5fb) to your PR and run it to validate its behaviour

fix: parser removing more than generics

@meiMingle You're right the correct syntax is ``````

Optimize `filterGenerics()`

@meiMingle I've added [this test ](https://github.com/Col-E/Recaf/pull/746/files#diff-4c558610d76d6de15e1e04b48b9cb3143d30c95e7d11f9b15736a4c99883e5fb)that fails with this PR: ```java @Test void dontRemoveGenericInString() { String code = "String x = \"Foo\";"; var res = filterGeneric(code); assertEquals(code, res); } ```...