Kuo-Chung Hsu
Kuo-Chung Hsu
> do you want to mark all the protobuf as not yet implemented just notice i already set `option (xds.annotations.v3.file_status).work_in_progress = true;`
@zuercher I addressed all the comments except this https://github.com/envoyproxy/envoy/pull/33919#discussion_r1599303324 which needs some input. Also add some trivial unit test, hopefully pass the coverage test
we got approval and api reviewed so i think we're good to merge. https://github.com/envoyproxy/envoy/pull/33919#pullrequestreview-2072613349
intend to add more tests but push earlier to see if ci is happy
> intend to add more tests but push earlier to see if ci is happy test added. @fishcakez or probably @PeterL328 could do the initial review to reduce maintainers' load...
@zuercher I could address Peter's minor comments in another PR if that's easier for merge work?
> @zuercher I could address Peter's minor comments in another PR if that's easier for merge work? nvm, i address comments and fix the conflict with current.yaml
rebase to be on top of https://github.com/envoyproxy/envoy/pull/34493