envoy icon indicating copy to clipboard operation
envoy copied to clipboard

thrift to metadata implementation

Open JuniorHsu opened this issue 1 year ago • 3 comments

Commit Message: After we introduced proto in #33919, here's the implementation of the filter. doc: https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/thrift_to_metadata_filter.html#envoy-thrift-to-metadata-filter

Additional Description: Risk Level: Testing: unit Docs Changes: Release Notes: Platform Specific Features:

[Optional Fixes #Issue] #29371

JuniorHsu avatar May 25 '24 02:05 JuniorHsu

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/). envoyproxy/api-shepherds assignee is @abeyad CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/34360 was opened by JuniorHsu.

see: more, trace.

intend to add more tests but push earlier to see if ci is happy

JuniorHsu avatar May 25 '24 02:05 JuniorHsu

intend to add more tests but push earlier to see if ci is happy

test added.

@fishcakez or probably @PeterL328 could do the initial review to reduce maintainers' load (actually the former already did some early feedback)

JuniorHsu avatar May 25 '24 04:05 JuniorHsu

other than minor comments lgtm

PeterL328 avatar Jun 03 '24 09:06 PeterL328

/assign-from @envoyproxy/senior-maintainers to approve and merge

abeyad avatar Jun 03 '24 15:06 abeyad

@envoyproxy/senior-maintainers assignee is @zuercher to assignee is @None approve assignee is @None and assignee is @None merge assignee is @None

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/34360#issuecomment-2145512184 was created by @abeyad.

see: more, trace.

@zuercher I could address Peter's minor comments in another PR if that's easier for merge work?

JuniorHsu avatar Jun 03 '24 15:06 JuniorHsu

@zuercher I could address Peter's minor comments in another PR if that's easier for merge work?

nvm, i address comments and fix the conflict with current.yaml

JuniorHsu avatar Jun 04 '24 18:06 JuniorHsu

/retest

JuniorHsu avatar Jun 05 '24 00:06 JuniorHsu

rebase to be on top of https://github.com/envoyproxy/envoy/pull/34493

JuniorHsu avatar Jun 05 '24 00:06 JuniorHsu

ci passes. phew

JuniorHsu avatar Jun 05 '24 20:06 JuniorHsu

@zuercher ping? this unfortunately now needs a main merge

alyssawilk avatar Jun 11 '24 12:06 alyssawilk

/retest

JuniorHsu avatar Jun 11 '24 17:06 JuniorHsu

/retest

JuniorHsu avatar Jun 11 '24 22:06 JuniorHsu

running out of disk, seems not related but unable to retest

JuniorHsu avatar Jun 11 '24 22:06 JuniorHsu

going to merge main again given unable to retest

JuniorHsu avatar Jun 11 '24 23:06 JuniorHsu

/retest

JuniorHsu avatar Jun 12 '24 03:06 JuniorHsu

2024-06-11T23:43:54.2174034Z [2024-06-11 23:43:53.958][35498][warning][main] [source/server/server.cc:908] caught ENVOY_SIGTERM
2024-06-11T23:43:54.2174838Z [2024-06-11 23:43:53.958][35498][info][main] [source/server/server.cc:1047] shutting down server instance
2024-06-11T23:43:54.2175631Z [2024-06-11 23:43:53.958][35498][info][main] [source/server/server.cc:987] main dispatch loop exited
2024-06-11T23:43:54.2176258Z ================================================================================
2024-06-12T00:46:17.3493256Z [32mINFO: [0mElapsed time: 4580.415s, Critical Path: 554.70s
2024-06-12T00:46:17.3494893Z [32mINFO: [0m37132 processes: 18721 remote cache hit, 13797 internal, 1 local, 4613 processwrapper-sandbox.
2024-06-12T00:46:17.3912927Z //test/integration/python:hotrestart_handoff_test                        [0m[31m[1mFAILED[0m in 16.5s
2024-06-12T00:46:17.3916359Z   /build/bazel_root/base/execroot/envoy/bazel-out/aarch64-opt/testlogs/test/integration/python/hotrestart_handoff_test/test.log

seems unrelated

JuniorHsu avatar Jun 12 '24 03:06 JuniorHsu