WeakRefStrings.jl

WeakRefStrings.jl copied to clipboard

setindex! incorrect for non-UTF-8 strings?

2

These two lines don't seem correct to me for non-UTF-8 `AbstractString` types: https://github.com/JuliaData/WeakRefStrings.jl/blob/caf4ed477e493309d12502ab0984eec157120925/src/WeakRefStrings.jl#L369-L370 Indeed this will copy the contents of the string even if it uses a different encoding from...

nalimilan

The following constructor should make a copy: https://github.com/JuliaData/WeakRefStrings.jl/blob/7da08fd778ed784e0ec3f96ef1981dca975891c0/src/WeakRefStrings.jl#L289 This is not a problem in practice when the input is not a `StringArray` since a new array will have to be...

nalimilan

We can optimize many things by intermediately switching to `StringArray{WeakRefString{UInt8}}` - [x] permute! - [ ] sort! - [ ] getindex with AbstractArray index

shashi

Remove hash method definition when Base.memhash is not available. On Julia 1.13+, these AbstractString types will use the default AbstractString hash implementation which is now efficient and zero-copy based on...

vtjnash