WeakRefStrings.jl icon indicating copy to clipboard operation
WeakRefStrings.jl copied to clipboard
verified publisher icon JuliaData

Constructor should make a copy

Open nalimilan opened this issue 7 years ago • 0 comments

The following constructor should make a copy: https://github.com/JuliaData/WeakRefStrings.jl/blob/7da08fd778ed784e0ec3f96ef1981dca975891c0/src/WeakRefStrings.jl#L289 This is not a problem in practice when the input is not a StringArray since a new array will have to be allocated, but we should add a method calling copy for StringArray inputs.

nalimilan avatar Feb 03 '19 12:02 nalimilan