Juha Tauriainen

Results 11 comments of Juha Tauriainen

Well, the only reason I did any changes to the code pattern was because eslint gave me 198 errors, all of which are now fixed in this PR.. Will resolve...

It would be great if this lib had tests, so we could be 100% sure we don't break existing functionality by accident.

Totally understood. Let's merge this after there's tests, so I we can be sure this pr doesn't break any existing functionality. I'll rebase and refactor once some tests are implemented....

@i-break-codes conflicts fixed

Sure I understand that, but a lot of the time img tags will not have width/height set, either by css or attributes. In my opinion there should at least be...

Sure! I'll try to get something for you during the weekend :)

This is awesome! 👍

This issue has been opened in 2015 and still open. Any progress on fixing this?

I had the same issue. I think it's caused by this projects package.json declaring react as dependency, not as dev or peer dependency. https://stackoverflow.com/questions/30451556/what-is-the-correct-way-of-adding-a-dependency-to-react-in-your-package-json-for