Joshua Watt

Results 46 comments of Joshua Watt

It is unfortunately a little hard to write automated tests for most of this since it requires actual hardware interaction, but I'll take a stab at it. I was able...

I added some tests, which revealed a few bugs that needed fixed. I think it's all good to go now though (although I still have no way to test barebox)

> Great work! I found some trivial things. I'll have to dive deeper into this later. > > This should be mentioned in `CHANGES.rst` and probably needs some documentation elsewhere?...

> I've tested this briefly now. > > Issues I stumbled upon: > > * `BareboxDriver` now times out on `run()` I don't have any way of testing barebox, can...

I think I've addressed most of the comment, is there anything else needed to merge this?

> How would you run a command that takes longer than 30 seconds? > > ``` > def test_async_output(strategy): > strategy.transition("shell") > with strategy.shell.popen("sleep 40") as p: > pass >...

> > How would you run a command that takes longer than 30 seconds? > > ``` > > def test_async_output(strategy): > > strategy.transition("shell") > > with strategy.shell.popen("sleep 40") as...

> > > How would you run a command that takes longer than 30 seconds? > > > ``` > > > def test_async_output(strategy): > > > strategy.transition("shell") > >...

@Bastian-Krause Ok, I tracked this down to a behavior difference is bash (which I was using) vs. busybox. I've corrected it and now it should work the same for both...

For those interested, the difference is: bash: ``` raspberrypi4-64:~# echo -n 'ABC'; sleep 10; echo 'ABC' $?; ABC^C ABC 130 raspberrypi4-64:~# ``` busybox: ``` raspberrypi4-64:~# echo -n 'ABC'; sleep 10;...