Josh McCullough

Results 125 comments of Josh McCullough

Temp. fix is to clear the env var before running your build e.g.: `GITHUB_TOKEN='' npm publish`

Any chance of merging this soon?

Oops, looks like I said I'd look into something then never did. But I agree, I'd love to have this merged in.

I started looking at this this weekend but I can barely get the tests to run. A lot are failing (as mentioned, but my number was off originally). I'm not...

Yes -- committed. After adding `-Prelease`, I get a new error message: >Determined tag '0.1.0-alpha.0' is filtered out by your configuration; this is not supported. >Check your filtering and tag-prefix...

Our existing tags all start with "v", so don't think they'd be included since we have not configured this to use a prefix. I was also surprised it wasn't picking...

I took a _very_ quick look through the code and it seems like this regex should be updated and/or modified so that it optionally includes the `tagPrefix`: https://github.com/vivin/gradle-semantic-build-versioning/blob/a1f125286bd776c5060386ba3ab0b388d2ca0972/src/main/groovy/net/vivin/gradle/versioning/VersionUtils.groovy#L24 Note that...

Ran into this as well. IMO the whole point of releasing pre-release packages is to work toward the final release version. It's very, very likely that the final release version...