Josh Brown

Results 13 comments of Josh Brown

Thanks, all good points. I find the qualities of clean and maintainable can often be very subjective so ultimately comes down to the choice of the maintainer. If we take...

Yeah I think on reflection of the suggestions here the FormBuilder approach paired with some helper methods gets us closer to that. I can put together a solution that utilises...

I've made some changes that brings this PR more inline with the recommendations from TW, and changes the default form builder to make it simpler to build forms that follow...

Sounds good, yeah I'll take a look and update, will change this PR back into a draft until I have something.

@Shpigford How's this? Should be updated with the latest styles across the entire app.

> I've made some updates based on your suggestions. I'm not too sure how I'm able to return a single type without aggregating them into a group. Also, let me...

Ah good questions! I've solved the reset, this was happening because the turbo frame was only being cleared - it still had the src set which means when the refresh...

I've updated the adapter for development, it just uses the Active Record's connection pool so nothing else to configure. I think for caching you can probably use Solid Cache if...

Btw, I think we can probably further simplify how the `valuation#create` action works. We could remove [valuations/create.turbo_stream.erb](https://github.com/maybe-finance/maybe/blob/7e324f1b53f38f669761c9ee169224a9b21fb83a/app/views/valuations/create.turbo_stream.erb#L1-L4) and replace it with a simple redirect. This would help reduce a chunk...