Joseph-Sarsfield
Joseph-Sarsfield
I've removed test_strict_require_batch_size_for_gpu, alternatively you could identify calls from map_groups vs map_batches and raise if not map_groups call but I think the developer should have the agency to change batch_size...
@jjyao please can I request review
> hi @Joseph-Sarsfield , thanks for you contribution. But I don't really understand the problem. Could you give a concrete example? Also, it'd be nice if this change only affects...
> thanks for the update. The reason of adding this limitation is that we want to let users to explicitly set the batch_size for GPU, to avoid expected GRAM OOMs....
Hi @raulchen @ericl, I've updated to pass a flag to determine calls from map_groups.