José Andrés Cordero Benítez
José Andrés Cordero Benítez
Hi @mreutegg, yes, the plan is to move to sync driver after the failing tests in this build are fixed. Apart from the documentation you have showed, I have this...
All checks have passed at this point, I will continue now the migration to sync driver in this same PR.
Thanks @mreutegg and @rishabhdaim for your reviews. I think I have addressed all the suggestions in the code. I would appreciate if you have more comments or give green light...
Will integrate this into tests in a future iteration (as stated in the ticket). This statistics are just informative and we could introduce potential flaky tests.
> actually, there are compilation errors: > > ``` > [INFO] ------------------------------------------------------------- > Error: COMPILATION ERROR : > [INFO] ------------------------------------------------------------- > Error: /home/runner/work/jackrabbit-oak/jackrabbit-oak/oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java:[367,11] setStatisticsProvider(org.apache.jackrabbit.oak.stats.StatisticsProvider) is not public in org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollector; cannot...
I will squash this PR into a single commit once approved.
Right now we are only getting the aggregated number of garbage that gets deleted, but we don't know which of the phases found it. This PR focuses on the garbage...
> +1, I don't have full overview of how many metrics this will introduce (i.e. whether that number might be excessive), but I think that's something that we'll see and...
Are there any concerns about increased memory usage by caching the Path object in memory in every case? I understand it can improve performance on indexing job, but it could...
Thanks @rgambelli, I have approved the execution of tests on our pipeline to see if tests are passing.