Jono Yang

Results 71 comments of Jono Yang

@KevinJi22 Don't feel compelled to amend your commit and force push it every time you make a change. You can create as many commits as you want on this PR....

@KevinJi22 After talking to @pombredanne, we'd like to modify the CLI option for external licenses. Currently, we have `-dir` and `--additional_directories` as CLI options, which we would like to change....

@AyanSinhaMahapatra I'll need a little more time to review this, but I think it's looking good so far. You have some failing CI tests, maybe some other test expectations need...

@pombredanne Will the Codebase-Resource model schema from commoncode be versioned in the same way as the JSON output or is the output format independent of the Codebase-Resource model schema?

On second thought, it makes more sense to sort the assembly items after the fact in scancode.io than it is to mandate every `.assembly()` method yields Packages, Dependencies, and Resources...

@pombredanne I've updated the rest of the `assemble()` methods to yield Packages before other assembly items. I tried sorting the output of the `assemble()` method in my code on scancode.io,...

@DennisClark The declared holder is Google because the summary plugin only considers detected holders from key files. The `LICENSE` file has a Google copyright statement at the end of it....

@KevinJi22 Part of me is not sold on creating a different entry point for external licenses just yet. I would go with the first approach you listed and mandate that...

It also may not behoove us to use the package authors as a copyright holder when we do not detect an explicit copyright statement from package data.

@DennisClark @tdruez @pombredanne When removing the code that assigns the author or other detected parties from a Package as the declared holder, I noticed that the tallies plugins does some...