Jonathan Ferreira

Results 14 comments of Jonathan Ferreira

Thanks @fibric, your step-by-step worked perfectly!

Use a versão ^2.1.3 ao invés da ^2.1.4 e atualize o react para a v17.

> Hey @Jonathansoufer, changes to component library LGTM! It would be great to get a detailed PR description with an included screencast with this PR Added.

> Is the settings icon on the Notifications list page hooked up or is just a placeholder for now? Settings was implemented [here](https://github.com/MetaMask/metamask-mobile/pull/9258), and

> Turn on notifications page's Learn more link needs a space to the left of itself ![Screenshot 2024-05-08 at 01 01 29](https://github.com/MetaMask/metamask-mobile/assets/44679989/0d5667cd-93b3-4005-a841-81c10fcb6a75) This is fixed and merged on main already.

> Are the sub toggles from the Notifications page functional yet and if so, can we provide videos/description on app behavior when those toggles are on/off Not. They'll be calling...

> The Notifications list page seems to also have extra padding below the header or is that by design? ![Screenshot 2024-05-08 at 11 25 24](https://github.com/MetaMask/metamask-mobile/assets/44679989/fb251d78-1b8f-4a99-8be6-723da61bca7c) Fixed.

> The row items on the notifications list on the Wallet tab seems misaligned vertically. For example, the icon and badge floats more towards the bottom whereas the middle content...

> Unless by design, the trash icon should either be center aligned vertically or aligned against the top, similar to the icon+badge Fixed.

> The Allow notifications toggle should remain off until a user taps Yes (currently, it slides right but back to the left) https://github.com/MetaMask/metamask-mobile/assets/44679989/9eb7d46e-724a-4afb-b20f-5b8b6fd5870f Fixed.