Jonas Gessner comments

Results 19 comments of


                                            Jonas Gessner

Improve UI testability

Hey, thanks for the PR! This looks pretty good, but without any concrete tests beyond a PoC this is not something I'd want on master. To be honest I wouldn't...

Use UIView animation instead of pop?

UIView can do the same if you pass UIViewAnimationOptionBeginFromCurrentState as animation option. So there's really no reason to use pop ;) I've also found pop to lag sometimes while UIView...

%subclass with protocols crashes in the constructor

I got the precompiled .mm version of the .xm source file, and in the constructor the two protocols are added to the class like this: ``` objc class_addProtocol(_logos_class$_ungrouped$CCSectionViewController, objc_getProtocol("CCSectionDelegate")); class_addProtocol(_logos_class$_ungrouped$CCSectionViewController,...

%subclass with protocols crashes in the constructor

Yeah. Checking if the protocol returned from `objc_getProtocol` is nil and falling back to `@protocol` would probably be the best solution.

EXC_BAD_ACCESS when swizzling AVAudioSession setCategory:withOptions:error:

Yes, NSError *\* is probably the culprit, where exactly is the exception thrown?

Crash when create a new JGActionSheetSection

Are you passing a valid value as button style?

Swizzling an instance method on the same instance twice causes it be to applied to all instances.

I'll check this out once I have time. Could you fork the repo and fix it yourself, then send a pull request? That would be great help!

handle downloading process when the data is low

I will look at this, but I'm not sure when I will have time.

Implemented "showFromRect:inView:animated:"

Awesome, this is something I wanted to implement a long time ago. I'll test it when I get some free time but it looks promising! Wicked!

Implemented "showFromRect:inView:animated:"

Thanks for reminding me. I'm super busy but I hope that I will be able to test this soon.