John Hope

Results 15 comments of John Hope

I suspect it's because you can't ensure the version-creating callback will be executed after all user-defined callbacks. I worked on [Redcrumbs](https://github.com/JonMidhir/Redcrumbs) and we had a similar problem. A user-defined callback...

I'm not sure that would work, you would still have problems with assignment of primary keys, foreign keys, `around_filter` etc. IMHO It's better to capture the object exactly as it's...

:+1: Thank you! Worked for me, and I've seen others use this approach. It should be added to the Readme as it's quite common IMO. Just needs a typo fix...

That's cool, and probably ideal, but I think it would be quite a common requirement that the adapter support namespaces in some way

If we could build a list of the methods that have to be delegated elsewhere for the class to be backwards compatible I'd be happy to do the work to...

There would probably be other conflicts besides the occlusion of the logger when trying to `include HTTParty` in an ActiveRecord model. I got issues with enum methods, for example, when...

This is probably common enough that it could be detailed in the docs. @jnunemaker could you review https://github.com/jnunemaker/httparty/pull/765 please?

Heya @KingsleyKelly, have you started work on this?

This patch would fix it. I tested with the benchmarking tool @TheSmartnik linked and it doesn't seem to reintroduce the memory leak: ```patch diff --git a/lib/httparty/text_encoder.rb b/lib/httparty/text_encoder.rb index 006893e..a8302d1 100644...

@anderson-lee Looks like a bug in that particular template implementation. There is a workaround though: https://github.com/alshedivat/al-folio/issues/1043