John Daly

Results 12 comments of John Daly

This change should allow for a new `react-query-devtools/build/umd/index.development.js` to be generated, which can be used to fix https://github.com/TanStack/query/issues/3916

> @JohnDaly it seems that this PR increased the bundle-size of react-query by 5x 😅 > > https://bundlephobia.com/package/@tanstack/[email protected] > > We can also see this in the bundlewatch logs: >...

> This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io). > > To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/mswjs/msw/pr/1356/builds/277254) or the icon next to each commit...

@kettanaito have you had a chance to review the latest changes?

> Hey, @JohnDaly. I've finally got to review the changes you've made and they are great! > > I've left two questions: > > * Whether the compiled sandbox is...

> Are any changes necessary here? `nextjs-routes` is currently extension agnostic. What issue are you running into? The changes in this PR will prevent non-page files from being included in...

> I'd like to look into reading `next.config.js` directly rather than pulling in `NextRoutesPlugin`. That would also be generally useful in the future. > > I'm curious how useful the...

> Got it. Would it be fair to summarize the motivation here to omit .test files from the generated routes? And using pageExtensions is an implementation option? The motivation is...

> @JohnDaly My inclination is to take this in a simpler direction: #54. This library has an easier problem to solve than NextJS because we don't need to locate the...

> Also, I didn't enable emotion in the compiler options because [the documentation](https://nextjs.org/docs/advanced-features/compiler#emotion) claims that it's enabled by default, at least when running in dev (which is very confusing btw):...