John Pocock
John Pocock
Just noticed that this may be fixed by https://github.com/pgjones/flake8-sql/pull/21
I have also encountered this issue. It is due to [the regex used to detect query strings](https://github.com/pgjones/flake8-sql/blob/0ed4d53dfed6d243254d9065646b17cf8f49708d/flake8_sql/linter.py#L12). Here are examples of false positive matches with the above docstrings: https://regex101.com/r/gYdthu/2 (see...
Some ways I can think of to avoid false positives like these for docstrings are: 1. Use a proper parser (e.g. with pyparsing) to check if a string is a...
I am also seeing this issue of oversized handles. The larger handles appear in Firefox (66.0.1 64-bit) but not in Safari (12.0.3). I am using leaflet 1.4.0 and leaflet draw...
Perhaps it would be helpful to construct a document, in our wiki perhaps, detailing what does and does not work in both systems as a reference guide when writing these...
RE our last toolbox meeting, many of the notebooks log errors when running `make docs`. Perhaps we should have a PR to address these issues. Edited by @DavidBAEpstein: @John-P How...
I believe this should be partly addressed by moving to myst-parser (from recommonmark) for Sphinx. Now the docs (sphinx/read the docs) and Jupyter are using the same markdown parser and...
One general comment is the name of the class. It is named functionally e.g. "Registration" rather than as an object e.g. "Register" i.e. 'the thing that does the registering'. I...
@mostafajahanifar, it's worth checking the default parameters (kwargs) for dictionary learning between scikit-learn versions. This has caused things to break in the past. In future, to avoid this we should...
@mostafajahanifar Looks like there was a change to dictionary learning in 0.23.0: https://scikit-learn.org/stable/whats_new/v0.23.html#sklearn-decomposition