Joseph Ho

Results 51 comments of Joseph Ho

Hello @SaraJaoude! I've created a PR for this issue and would love you to have a look at it and leave a review.

Doesn't seem like this issue has any activity recently. May I take on the issue?

Hello @alya! This PR is also ready for review, please have a look at it!

@alya I've finished fixing the issues and it is ready for review.

Created new testcases for the new bot responses but it's currently not working and results in a response that differs from the expect response. Currently waiting for some help to...

Thank you for the review! It was very insightful and I was able to make the changes needed. It was very interesting to me that the test cases doesn't fill...

Hello @laurynmm! Thank you for the review again, I've made the changes you've suggested. Please have a look again and let me know if there should be anymore changes.

Currently I don't see a way to retrieve the resolved_topic_message_id. If I understand this correctly, I should make changes to `maybe_send_resolve_topic_notifications` and make it return the message ID of the...

Sure, I'll make a sperate commit for it. I've gotten that part down but I'm not sure how to really address the security issue. Do we do a `bulk_access_messages` on...

Took me a while to understand the security issue and I think I should have it down now. Will do a bit of finishing touches and manual testing before pushing...