Joe Loser

icon indicating an email [email protected]

icon company Modular icon location Denver, Colorado icon location Engineering manager, Libraries (Mojo standard library and more) at @modular

Results 762 comments of Joe Loser

Can't link folly, "undefined reference to `boost::re_detail_106400::cpp_regex_traits_implementation<char>::transform"

@mittalrishabh which Boost version and which compiler was used to build that Boost version? I've run into `Boost.Regex` bugs with certain tuples of {Boost version, GCC version} at my employer....

libc++ should ship an IWYU mapping file

I'd love to see this worked on. It's not ideal to maintain `libc++` mappings internally outside of IWYU in a codebase for example as it quickly gets out-of-date with the...

Add -Wtype-limits to -Wextra for GCC compatibility

I'm in favor of this. @nico have your opinions changed on the matter of matching GCC with `-Wextra` in some things like this (based on your comment from https://reviews.llvm.org/D51545)?

clang 14/15 libc++: std::vector memory leak in case of iterator exception

CC: @philnik777

[mojo-compiler] CompTime interpreter should be able to fold `pop.call_llvm_intrinsic`

I've renamed this issue to track the general problem from my observations this past week. From our internal Mojo discussion on this yesterday, we do want to implement support for...

[BUG]: Naming in Mojo is inconsistent and lacks of coherent vision

Thanks for filing this issue and your commentary. I 100% agree the current status quo of naming leaves a lot of room for improvement. _Personally_, I prefer the `_` separator...

[mojo-stdlib] Add `list.pop(index)` API

> Could you point to the current `pop_back` implementation? Of course. [This](https://github.com/modularml/mojo/blob/76d05839487905d6c7459c7135fdb5bb9f23f336/stdlib/src/collections/list.mojo#L229) is the current implementation. I recommend we add a new function: `pop(index: Int)` and preserve the `pop_back` for...

[mojo-stdlib] Add `list.pop(index)` API

Fixed by https://github.com/modularml/mojo/commit/0e94191609a286eecddafe6e149240c50f07c8dd

[BUG] Segfault in stdlib's CI, in `builtin/test_reversed.mojo`

Is it because of https://github.com/modularml/mojo/commit/abf2975d48fc7631e0e2ca741340289ec622f5d0? Want to try reverting that and see if it passes consistently on CI? It just merged a few hours ago.

[BUG] Segfault in stdlib's CI, in `builtin/test_reversed.mojo`

@ConnorGray FYI - something to keep an eye out for if you see any flakiness this week for CI