George

Results 23 comments of George

I can paste my implementation of log system based on `tracing` that solves some issues. Code isn't so big!)

> While technically correct, I wouldn't introduce a mutable variable that really doesn't have to be mutable. You can fix the weird formatting by extracting the `.len() - 1` part...

> Why not just > > ```rust > let new_index = (editor_tab.active +1) % editor_tab.children.len(); > ``` Pretty good solution :D Thank you!!!

@alexkirsz What's the reason to use `mimalloc` instead of `mimalloc_rust`?

> @Jerrody `mimalloc` is the most well-maintained of the two. How did you understand? Both of them are `1.7.6`. Also, `mimalloc_rust` has an exposed `mimalloc`'s API. I don't think that...

> @Jerrody `mimalloc` is the most well-maintained of the two. This is the first thing, the second is what's the purpose of creating a `TurboMalloc` why don't use this: ```rs...

> You still need to explicitly declare `extern crate` if you mean to use an allocator declared this way in another crate. I find the `#[global_allocator]` declaration clearer. In fact,...

> > You still need to explicitly declare `extern crate` if you mean to use an allocator declared this way in another crate. I find the `#[global_allocator]` declaration clearer. In...

> Hey @Jerrody we already use clippy in CI (and preferably in development). > > You can check the code linting by running `make check` which is effectively: > >...

> Assume we have > ```sql > > CREATE obj SET 1 = "foo", ONE = "bar";; > [{"time":"5.921978ms","status":"OK","result":[{"1":"foo","ONE":"bar","id":"obj:g47it0dzzeppxo0qjqg4"}]}] > ``` > > The following query (similar to your second...