Jere Leppänen

Results 18 comments of Jere Leppänen

fix libcli version definitions

This would be nice. But I would suggest adding the following, for compatibility: ``` #define LIBCLI_VERISON_MINOR LIBCLI_VERSION_MINOR #define LIBCLI_VERISON_REVISION LIBCLI_VERSION_REVISION ```

[PATCH v20] validation: pktio: evaluate bad checksum

Looks good, but would you be willing to do the same also for pktio_test_chksum_in_ipv4?

[PATCH v2] linux-gen: event: add event validation support

I'm not a huge fan of the word myself, but should we use "canary" instead of "endmark"? https://en.wikipedia.org/wiki/Buffer_overflow_protection#Canaries

[PATCH v2] example: classifier: improvements for performance testing

> Perhaps a more stringent CLI input validation could be considered if this is now becoming a proper tester No more proper than it already was. I don't think we...

[PATCH v3] helper, test, example: avoid strncpy()

v2: - Fixed string.h doxygen comments.

[PATCH v3] helper, test, example: avoid strncpy()

v3: - Rebase. - Add review tags.

[PATCH v2] api: timer: require an array of timeout events in odp_timer_periodic_start()

v2: Add commit "api: timer: add periodic.max_tmo_events in timer capability".

[PATCH v4] linux-gen: avoid some GCC thread sanitizer warnings

All comments processed in v2.

[PATCH v4] linux-gen: avoid some GCC thread sanitizer warnings

v4: - Use acquire and relese semantics on is_idle. - Reorder commits. - Minor tweaking of some commit comments. - Add review tags.

[PATCH v4] fix issues reported by GCC address sanitizer

I took the liberty of updating this PR with all the comments processed, commit comments cleaned up a bit, and a couple of new warnings fixed (ML).