Jeffrey Carl Faden

icon indicating a website link jeffreyatw.com icon indicating an email [email protected]

icon company Apple icon location Berkeley, CA

Results 13 comments of Jeffrey Carl Faden

fix(directive): check for existing elements before appending

@passy Fixed the specs to reflect the general use of `ng-repeat`, except in the case of static elements.

Items loaded twice

#167 should fix this.

on-select-all="fSelectAll()"

Can reproduce here. The output model is updated, but only AFTER the `on-select-all` callback has occurred. We need to do a `$watch` on the output model instead, which to me...

on-select-all="fSelectAll()"

Yes, happens in both.

on-select-all="fSelectAll()"

Nope, we have that set. It works for `on-item-click` but not `on-select-all` or `on-select-none`.

on-select-all="fSelectAll()"

Yes.

<FileInput /> doesn’t assign a button ID when files are added

I think the FileInput should replicate what happens within the [`_onInputChange` method](https://github.com/FineUploader/fine-uploader/blob/0dd03695baf590c2d31393723e64b0b3a669607c/client/js/uploader.basic.api.js#L1489). Prior to adding files, it annotates the file with the current button ID. (The button ID is generated...

Emails are case-sensitive

Thanks! I'll work on making emails case insensitive.

Make it easier to call the venue

There's upsides and downsides here. Currently you can click the address to go directly to the Google Maps place page, with the phone number there. If we extracted the phone...

Validation not working after reset

If you call `reset`, the next call to `defaultShouldValidate` returns `false`. That's because it compares previous values to new values to see if it needs to validate, but it's comparing...