Jyotirmaya Shivottam

Results 112 comments of Jyotirmaya Shivottam

@bootje2000 Apparently some attributes have been renamed or moved around (prima facie). Try this slight modification to @felipegb94's workaround: ``` surf._facecolors2d = surf._facecolor3d surf._edgecolors2d = surf._edgecolor3d ``` Note the lack...

@nina-wwc I just checked the minimal working example in this thread using `matplotlib-3.5.1` and `3.5.2` (latest) and my workaround works as it did before, as does yours. Could you test...

@QMrpy This can help with the checks: https://github.com/einsteinpy/einsteinpy/wiki/Development-tips

@QMrpy Can you add links to the resources you are using, for the coordinate conversion, here?

> @JeS24 I used https://arxiv.org/pdf/0904.4184.pdf and https://arxiv.org/pdf/0706.0622.pdf , equation (34), (35), (36), (47) for the conversions. Also, I referred to the standard Wikipedia articles on these coordinates. Thanks. > I...

@aweinr4 Thanks for opening the issue. I think a general `from()` function is a good idea, for all the reasons you've mentioned and it makes for cleaner API. And overall,...

The scaling factor has been removed in #512, with tests still giving same results as the previous code, indicating some issue in the implementation in `KerrNewman`.

> is this issue open for work @shreyasbapat @godslayer201 @rajpratyush Yeah. You may work on it.

Won't `sympy` make everything slower? For numerical problems, this does not seem like a practical approach.

@Atheriz-46 Sure, but as mentioned by others, this issue is tricky due to the way `numba` and python work.