Jayshil A Patel
Jayshil A Patel
Dear @pmaxted, I have opened a pull request for this -- I have kept [pycdata](https://github.com/Jayshil/pycdata) an independent package as of now because I didn't know your plans with `pycheops` (let...
Hi @nespinoza, I am not really sure if this is the only way to make this work or not. There may be other ways to resolve this issue that I...
Hi @nespinoza, A colleague of mine pointed out that instead of editing the `juliet` source code, one can simply add the following two lines in their code to make multiprocessing...
Hi @LucaNap (cc @nespinoza), I think this may be a real issue with `juliet`, and it likely happens because of a large number of data points. The total number of...
Hey @gavinxwang, Great! Thanks for trying and reporting back that it is working. Although I am writing docs for this and there are test files included in the PR, feel...
Hey @nespinoza, Maybe I misunderstood, but I thought the light travel time delay was already implemented for phase curve models as well. For example, [in this line](https://github.com/Jayshil/juliet/blob/daae9678b80e859bf77e9f80470ee3458724a6d7/juliet/fit.py#L3911), when we initialise...
Hey @nespinoza, I briefly looked into this. The `correct_light_travel_time` function in `utils.py` seems to be correcting for _all_ times (as I show in this [gist](https://gist.github.com/Jayshil/60487cf9a7e3ccfd84632a44d84c6cb8)). I also did a kind...
Hey @nespinoza, I have implemented all that I wanted to in this PR, and also wrote [documentation](https://github.com/Jayshil/juliet-examples) to explain new models. This PR is ready to merge from my side....