Jenny Bai

Support ItemDefinitionGroup in Choose/When

2

Fixes [#5436](https://github.com/dotnet/msbuild/issues/5436) ### Context ### Changes Made There is a significant error in the original Constuctor ProjectItemDefinitionGroupElement(XmlElement xmlElement, ProjectRootElement parent, ProjectRootElement containingProject). The second parameter and third parameter types are...

Add the missing help messages for some switches

6

Fixes [#9710 ](https://github.com/dotnet/msbuild/issues/9710) ### Context Some of the supported command line switches are not mentioned in the help message ### Changes Made List the relevant string resource ID in s_parameterlessSwitchesMap...

Update the condition GenerateTargetFrameworkMonikerAttribute

1

Fixes [#9840](https://github.com/dotnet/msbuild/issues/9840) ### Context https://github.com/dotnet/msbuild/blob/9af8ff2f951017996172e5b805651ebf957e97f4/src/Tasks/Microsoft.Common.CurrentVersion.targets#L3667-L3689 The condition on the target doesn't match the condition on the WriteLinesToFile task. So get this  ### Changes Made Add and '$(TargetFrameworkMonikerAssemblyAttributeText)' != ''...

Add build check result errors into the list of build submission IDs that have logged error

1

Fixes [#10071](https://github.com/dotnet/msbuild/issues/10071) ### Context While building with buildcheck enabled and MSBUILDNOINPROCNODE=1 Severity of the rule set to Error, does not reported to the all build:  This is since buildcheck...

[Bug]: Escape , and ;= doesn't work for global property when build with dotnet, but html encode %3C and %3B= works well

1

### Issue Description 1. Test escape ',' and "," and %3C in the powershell , cmd, bash and zsh. Found "," and ',' is not supported in the following 4...

[Flaky test] Microsoft.Build.UnitTests.Exec_Tests.Timeout

5

Microsoft.Build.UnitTests.Exec_Tests.Timeout ### Details https://dev.azure.com/dnceng-public/public/_build/results?buildId=385968&view=ms.vss-test-web.build-test-results-tab&runId=8250290&resultId=105001&paneView=history https://dev.azure.com/dnceng-public/public/_build/results?buildId=385824&view=ms.vss-test-web.build-test-results-tab&runId=8245228&resultId=104901 `Assert.Equal() Failure\r\nExpected: 1\r\nActual: 2` `at Microsoft.Build.UnitTests.Exec_Tests.Timeout() in D:\a\_work\1\s\src\Tasks.UnitTests\Exec_Tests.cs:line 133`

Shorten the path always when actually passing the long paths

6

Fixes [#4272](https://github.com/dotnet/msbuild/issues/4247) ### Context https://github.com/Microsoft/msbuild/blob/94e11e0a773bc8956caf128335433231bb06fed5/src/Build/BackEnd/Components/RequestBuilder/IntrinsicTasks/MSBuild.cs#L314 . https://github.com/dotnet/msbuild/blob/85b71777ad1e46a29e7a8dc24932df83edf1d218/src/Shared/FileUtilities.cs#L1192-L1199 In the function AttemptToShortenPath, It is only dealing with the path is long than the max path. So, when project path includes multiple...

Fixes [#10171 ](https://github.com/dotnet/msbuild/issues/10171) ### Context MsBuild produces unlocalized messages for some specific validation cases that happen in scope of target. The example of the task usage: https://github.com/YuliiaKovalova/msbuild/blob/be21253d85f7766356880d376e26aaa69c34c4cd/src/Tasks/Microsoft.Common.CurrentVersion.targets#L862 ### Changes Made...

Fixes [#8785 ](https://github.com/dotnet/msbuild/issues/8785) ### Context Re logging, the XslTransformation task calls TaskLoggingHelper.LogErrorWithCodeFromResources(string messageResourceName, params object[] messageArgs). There is also TaskLoggingHelper.LogErrorFromException(Exception exception, bool showStackTrace, bool showDetail, string file), which logs the...

Add opt-in for default channel registrations check Fixes [#11214](https://github.com/dotnet/msbuild/issues/11214) The error output is more explicit after the change