Jared
The loop before was only looping through 31 players and was causing massive hitches. This code fixes the problem. I only implemented the fix for 31 players, but you are...
Oh true we could use that too. The code before was causing massive timeouts and lag, so I fixed that part. Room for optimization of course still
Precisely. It's a simple fix, but I found it odd that its not using the much safer `GetActivePlayers()` and instead using a loop of 32.
Apparently this doesn't even work anymore so it's pointless now. Hopefully someone can remove it all-together in a pull-request in the near future. I'll leave this open until then.
> > Apparently this doesn't even work anymore so it's pointless now. Hopefully someone can remove it all-together in a pull-request in the near future. I'll leave this open until...
Fix for https://github.com/bitwarden/clients/issues/9159
Resolved code comments
> > Resolved code comments > > @JaredScar Thanks for coming back and updating the PR. The comment remarked for removal in https://github.com/bitwarden/clients/pull/16411/files#r2348956071 is still present. Resolved! Good catch!
> @JaredScar looks like this broke some importer tests where the notes field now has `\n` or other control characters at the end of it. Should be a quick fix...
> > Is there a way I can reproduce this to patch it up? > > Execute `npm run test` in a terminal from the base repo directory to run...