Jan Wittler
Jan Wittler
Seems this suggestion is accepted. I did not find any documentation on the supported C++ and Scheme version (and Python only 3 but not which minor) which is why there...
Language frontend finished (to an initial extend). I tried to test as many of the common constructs as possible and also applied the frontend to some local files of myself....
https://github.com/jplag/JPlag/blob/0780fc49c5d37c70f172f9d8289ddc158b6de934/jplag.frontend-utils/src/main/java/de/jplag/TokenList.java#L34-L45 I would like to remove the `TokenList` data structure entirely for which we have to get rid of this custom add functionality. The first part (ll37-39) with the file...
> @JanWittler all I know is that the `TokenList` is currently used to determine the matches of a comparison: > > https://github.com/jplag/JPlag/blob/0780fc49c5d37c70f172f9d8289ddc158b6de934/jplag/src/main/java/de/jplag/reporting/reportobject/ReportObjectFactory.java#L156-L171 > > The information on matches is then...
The aim of this PR is to make the core algorithm understandable by looking at the code, without reading the paper. From my perspective this is now given, thus the...
@jplag/maintainer I think there is no other PR anymore blocking this one, so it is ready to merge from my side. The end2end tests all run successfully, so I would...
> * View JUnit DynamicTest and its use in the OverAllTests cases. https://www.baeldung.com/junit5-dynamic-tests Here is an example. In best case the dynamic tests would be generated nested, but I didn't...
I tried to help you save some time by already providing an adjusted JSON scheme > ``` > [{ > "options": {"minimum_match_length" : }, > "tests": > { > :...
Overall looks good to me :) Some hints: - The code of `dynamicOverAllTest` returns after having collected tests for one language instead of for all. However, as Timur said earlier,...
> The end-to-end tests are only supposed to run for the Java language frontend. So I think this should be fine. [by Timur](https://github.com/jplag/JPlag/pull/583#issuecomment-1214846836) If you can make it work for...