JamesWidman

Results 24 comments of JamesWidman

[updated the "breaking changes" section]

re `src/window/settings.rs`: I'm not sure if I implemented serialization/de-serialization correctly (or if there was a way to avoid doing anything explicit here); comments on this would be very much appreciated!

cc @clason (another mac user) Please feel free to test and let me know if it breaks anything!

> I dont use `M` in hotkeys much so if there is more specific test of what to look for please let me know. The test results you gave (particularly...

Aaaaand i just realized that this part of the git commit message: > This is now fixed by relying on winit to supply the transformed printable character (i.e., winit produces...

> @JamesWidman. The ctrl shift fix is merged to main now, so once you rebase the PR should be easier to review. The CI also complains about some formatting issues,...

> On this most recent code from 1hr ago, `` in insert mode echos an error to the console: `Pattern not found: eventloopbuilder` (weird) That *is* weird... I'm having trouble...

@9mm > I also tried git grep 'Pattern not found' in both the neovide repo and the winit repo; no hits. I'll try looking in the local cache of all...

@9mm i think it's probably not coming from the iToaster though, because from a local clone of the winit repository, when we do: ```sh git log -p -SEventLoopBuilder ``` ...we...

> I'm pretty sure `Pattern not found: eventloopbuilder` comes from the built-in search. Ah... this seems to be it. So, I've confirmed that I don't have any mappings (insert mode...