James McMahon

Results 16 comments of James McMahon

Can I ask: _should_ we be extending tokens? I've not thought very long and hard about it, but I'm instinctively against the idea (I don't know why yet, I might...

I can answer (2) and (3): 2) absolutely, more options are always welcome if they're useful and easy to configure 3) Because no-one using the package has needed/wanted to do...

@peterthomassen Everything you say makes sense. To answer the question about why the salt was originally included, the answer is I honestly don't remember. I'm sure I had a good...

Hi @Khalidm98 Sorry for the slow response, It's try I don't have a huge amount of time for this project any more but I try to keep on top of...

I think this is a good idea :) Happy to take this on board with tests and docs

Hi, I'll try to remember to take a look this weekend. Feel free to drop me a line if I haven't done as I'm pretty busy and forget to check...

@max-wittig Approved, can you fix the merge conflicts and I'll merge it :)

Hi @max-wittig, yes I won't merge anything else until this one is done now - sorry for the trouble. Can you look at why the tests are failing though please?

Merged, I'll try to get a release done soon as we've had a few merges this month

Apparently I wasn't thinking when I wrote the answer last time, because I agree with @johnraz - Django already has Session auth if I remember correctly, what is the benefit...