JakeQZ

Results 205 comments of JakeQZ

> there so far was no point in having that switch here We're storing the `.phar`s under version control and running the update on a build server (actually just GitHub...

This is not likely to be an significant issue in the real world, but is something we have found in testing. I am just logging this so that it is...

This jogs a memory. I have used [`class_alias`](https://www.php.net/manual/en/function.class-alias.php) to mitigate migrating to namespaces and PSR-4. It was a godsend, IIRC.

> When the rule value is an identifier, it will be a string stored in `mValue`: Would introducing an `Identifier` (or `Keyword`) subclass of `Value` help resolve this? Such a...

We could provide a link in the readme to a tag for the last release which includes the functionality, to help anyone who wants to include it in their own...

Yep, I find the issue is in strict mode only. In lenient mode, `@media` and `@supports` are parsed correctly. In strict mode, an exception is thrown for either (and also...

+1 to all of these similar issues. In some cases, a concrete base class might work better, but that can be judged on a case-by-case basis. Changes will affect the...

Would using `psr/log` allow us to provide a 'null' logger by default, possibly meaning we don't need to actually additionally provide an on/off switch?

> Maybe `Comment.contents` or `Comment.text`? `DOMDocument` uses `textContent`, which suggests using `sContent` here to be consistent with both that and the Hungarian notation used in this project.

My concern with renaming properties and methods, particularly if they are `public` (though also if they are `protected`), is that it would be a breaking change. PHPUnit renamed some of...