Jacob Hayes

Results 43 comments of Jacob Hayes

Tests are broken due to https://github.com/dask/dask/pull/9020#discussion_r867429175 - I think that's a separate `.cov` incompatibility w/ the pandas version. I haven't had time to look in to see if that'd be...

Looks like there's a [difference in 3.8](https://github.com/dask/dask/actions/runs/2679361066) where pandas returns an int64 dtype while dask returns a float64 (tests also failed on 3.9/macos, but I think that was just a...

Ok, I think this is because `pandas==1.2.5` is installed for 3.8 (`pandas==1.3.5` is used for 3.9), which doesn't use the `int64` type. For now, I changed my tests to explicitly...

I think the two failing tests in the latest commit are flakes, or at least unrelated: - `dask/array/tests/test_reductions.py::test_reductions_2D[f4]` - `dask/tests/test_distributed.py::test_blockwise_dataframe_io[True-None-hdf]` I think all of my commits have had flakes (ignoring...

FYI: I think this is an issue upstream with ONNX (hence nothing for bonito to regenerate) with the fix [merged today](https://github.com/onnx/onnx/pull/4223). It should be in the next release, but I'm...

FYI: I think newer versions of mypy are a bit more strict about `dict.__ior__`, so I'll include a quick "fix" for that in this PR (that's why the first commit...

Sounds great! Feel free to add any new tests and I can take a stab at them if they don't work right away.

> (Not required for round 1), look into expanding this to work with BoxList as well. How do you think Boxes _inside_ BoxLists should be named? Eg: should `{"a": {"b":...

If this extra `__eq__` check makes sense, please review when you have a minute @PrettyWood! 🙇

Hmm, this works fine for simple models, but doesn't work on nested ones as they are just turned into and compared as dicts. Any suggestions on how that should be...