Jackson Campolattaro

Results 24 comments of Jackson Campolattaro

> I'm wondering if it's feasible to require Gtk 4 with 5.0? That has [FilterListModel](https://docs.gtk.org/gtk4/class.FilterListModel.html) and [SortListModel](https://docs.gtk.org/gtk4/class.SortListModel.html) which would be useful for using FlowBox for the cover grid (See #2840)...

I have a partial solution [here](https://github.com/JacksonCampolattaro/quodlibet/blob/1b7bc13eaf6bc1dab4906871d20eaf684fae4c70/quodlibet/qltk/filesel.py#L196), which uses [natsort](https://pypi.org/project/natsort/) to display files in a more appropriate order. Before turning this into a more complete PR, will the additional dependency make...

> > I have a partial solution [here](https://github.com/JacksonCampolattaro/quodlibet/blob/1b7bc13eaf6bc1dab4906871d20eaf684fae4c70/quodlibet/qltk/filesel.py#L196), which uses [natsort](https://pypi.org/project/natsort/) to display files in a more appropriate order. Before turning this into a more complete PR, will the additional...

Natsort wasn't being used in a particularly advanced way, so I was able to [replace it](https://github.com/JacksonCampolattaro/quodlibet/blob/natural-sorting/quodlibet/qltk/filesel.py) with a lexicographical sort of a regex split.

The class name `AABB_traits_construct_by_sorting` is descriptive, but now that we have some benchmarks it might be worth considering renaming it to something like `AABB_traits_fast_construction`. A new name could be a...

> Any updates on this? Hi! Sorry, I've been a little bit sidetracked starting a new job; I might be able to put together some unit tests later this week...