Jack McCracken comments

Results 10 comments of


                                            Jack McCracken

Add a 'report only' feature where activerecord models will not blow up when firewalled but will just log

This is good for review now (no longer WIP)

Add a 'report only' feature where activerecord models will not blow up when firewalled but will just log

I pulled the commit that had rubocop & style changes. I'll add this in a separate PR to keep the diff clear

Toxiproxy API access from browser

Hey @xthexder! Thanks for pointing this out. I think that was changed after the PR shipped. Validating the `Host` header seems like a sane way to deal with this. I...

Toxiproxy API access from browser

Hey, sorry for the delay but this is the actual hackerone report related to this: https://hackerone.com/reports/236349

Semantically parse and deduplicate source expressions

@machisuji if you have time, your review would also be appreciated here having worked in this area very recently 🙇

Semantically parse and deduplicate source expressions

Meta-concern: is this change a breaking one? I don’t think we have an easy way to differentiate between the quirks of this implementation and the other one. Those quirks weren’t...

Escape / and > also so apps cannot be broken by browsers trying to 'correct' the HTML

Oh whoops, I didn't know I was opening this on the main repo. :) Sorry for the small description. In Firefox, any of the props containing `

Escape / and > also so apps cannot be broken by browsers trying to 'correct' the HTML

Additionally, for the failing test, it seems to also fail on master so not sure how to fix it.

do my wheel !

Don't mean to be ignorant, but what does this do?