John Murray

Results 11 comments of John Murray

That makes sense, so are you saying to make a new version of the rapier plugin and have the old one just call into it?

ooo your talking about "root" plugin here https://github.com/JRMurr/heron/blob/2605f414e7536d148f93a8489be5a708d1cb3c05/src/lib.rs#L159 and not the "interal" rapier plugin here https://github.com/JRMurr/heron/blob/2605f414e7536d148f93a8489be5a708d1cb3c05/rapier/src/lib.rs#L52. Yea that should be a simple fix

ahhh ok that makes more sense, will do!

It looks like the tests running `cargo test --no-default-features --features debug-2d` are getting a linker error for some reason. Its not happening for me locally (granted i do have a...

@jcornaz I think its good for review, my test here https://github.com/JRMurr/heron/blob/2283b5974385765cb61b4c0b65dd611c32dd5aa0/rapier/tests/resources.rs#L92 is a little cheeky its just checking that https://github.com/JRMurr/heron/blob/2283b5974385765cb61b4c0b65dd611c32dd5aa0/rapier/src/lib.rs#L141 are added.

Yea for my current implementation i was feeling iffy on the `PhysicsTime::update` stuff. For rollback you would need a constant physics tick rate and re-simulating multiple steps as it is...

Hmm tbh im still a little confused on what each stage actually does. Do these comments describe it mostly correctly? https://github.com/JRMurr/heron/blob/2283b5974385765cb61b4c0b65dd611c32dd5aa0/rapier/src/lib.rs#L73 I think not configuring `step_physics_stage` is possible if i...

> Ah ok. I didn't understand that correctly. So basically you do need to define where all of them run (physics-time update, rapier-update, bevy-update). Is that correct? Yea, the idea...

I'll take this one! As a note for future reference, i found this issue https://github.com/bevyengine/bevy/issues/2160 and rfc in the main bevy repo https://github.com/bevyengine/rfcs/pull/33 which describes this issue in more detail...

Another rfc that would impact this in the future possibly https://github.com/bevyengine/rfcs/pull/45