Josha Dekker

Results 9 comments of Josha Dekker

Thank you! What I meant is that VS Code tells me "The default interactive shell is now `zsh`" when I select `bash`, which I originally interpreted as a message from...

@ChrisRackauckas You are right; however, the conditions should be equivalent here vis-a-vis the domain restrictions (both variables are non-negative, so both constraint functions cannot become negative either; any non-positive lower...

#10531 defines `CardinalInterFilter`, I'll make sure that both PRs use similar design choices. I believe it should be possible at some point to conclude that `cocardinal` filters (cardinality `c`) are...

I've removed the 'Awaiting-Review' label for now, as I'll first build up the theory of `CardinalInterFilters` more, these were introduced in #10531. Once this is finished, this PR will also...

This PR has been closed in favour of a newer PR, which makes better use of the recently added `CardinalInterFilter` file.

A further point (that is also raised in the thread linked above) is that using `product_distribution` with different types of distributions introduces type instability. Is there a way in `Distributions.jl`...

> Note also that Distributions.Product is deprecated, which probably explains why it hasn't been developed further lately. This is why I used `d = product_distribution(v_dists)` indeed > The tuple version...

> > This is why I used d = product_distribution(v_dists) indeed > > `product_distribution(::Vector)` still creates a `Distributions.Product`. I see, I didn't notice that! Thanks!

> As I suspected, likely a few methods can be improved for tuples. But note again that the version you're benchmarking against is not correct in general. I agree that...