Isaias Carvalho

Results 10 comments of Isaias Carvalho

I think so. I was able to build without using `kerl`, but when tried (using asdf) didn't work. That explains why. And I was on Arch too.

By that you mean a new tab? You're right. It really says that but opens in the same window. In [this line](https://github.com/consul/consul/blob/63820fb59fa4f9af0d1d6f13b50a9ec2756f2b02/app/views/users/registrations/new.html.erb#L44) the target is set to "_blank", but the...

I'll try to find it out why isn't working.

I've found the cause. The ActionView Sanitizer helper isn't allowing the target tag. As you can see [here](https://api.rubyonrails.org/classes/ActionView/Helpers/SanitizeHelper.html) Just adding this to the `application.rb` file solves the problem. ```rb #...

Reading the #4223 issue I think that's intentional, @javierm ?

I think so. Open the terms in a new window makes more sense to me, since stop the registration, load a new page in the same window to read them,...

@javierm You mean adding `target` to [this line](https://github.com/consul/consul/blob/2490d5e2093e682f31263fe4ff8a9514ff6d40a2/lib/wysiwyg_sanitizer.rb#L7)? If so, tried that and didn't work.

I don't know if this still up or if its already done, since its from last year. I think its a good idea. So, what's the actual situation?

For some reason, with the actual version now the label is no more in the format `ISSUER:email`. Now `otp_provisioning_uri` only need the email and the issuer as a second parameter....

An update: I've solved this by decoding the URI, but haven't figured out what's the cause of this. Since the [ROTP](https://github.com/mdp/rotp) gem is actually in `6.2.0` and this gem seems...