James J

Results 15 comments of James J

@sudara > I'm wondering what size image is this on? It would be nice to know if blurring X amount of pixels is possible at > 60fps... Those benchmarks were...

The `RealtimeObject` identifer doesn't seem to have been defined anywhere. I fixed this by replacing ``` 34 return RealtimeObject (false, std::forward(args)...); ``` with ``` 34 return RealtimeMutatable(false, std::forward(args)...); ``` and...

No, it still outputs the "Missing argument" message!

Should the `AND_REQUIRE` macro really be `AND_THEN_REQUIRE`? It's a bit cumbersome I know (especially if you also add `AND_THEN_REQUIRE_FALSE`) but `AND_REQUIRE` sounds more like it should come after a normal...

Have you thought of adding `THEN_CHECK` as well?

This would go nicely with https://github.com/juce-framework/JUCE/pull/1333 to make constructing value trees even cleaner: ```cpp juce::ValueTree {"Root"} .setProperty("foo", 10) .setProperty("bar", 20) .appendChild (juce::ValueTree {"Branch"} .setProperty ("x", y) .appendChild (juce::ValueTree {"Leaf"})) .addChild...

It looks like the interpreter is observing the changes, but possibly something is still trying to access the old tree after it's been replaced! I'm surprised that's not covered by...

Ahh okay, I've now remembered why the interpreter doesn't listen for `valueTreeRedirected()` - because the caller takes a `unique_ptr` to the `jive::GuiItem` produced by the interpreter, the interpreter can't then...

> I think we'll need a slightly different approach where the interpreter itself takes ownership of the GuiItem it creates so that it can replace it when the value tree...

``` juce::VariantConverter::fromVar(const juce::var &) jive_Display.cpp:13 jive::fromVar(const juce::var &) jive_VariantConvertion.h:45 jive::Property::getFrom(const juce::ValueTree &) const jive_Property.h:385 ::operator()(const juce::ValueTree &) const jive_Property.h:440 jive::Property::getFrom(const std::variant &) const jive_Property.h:438 jive::Property::get() const jive_Property.h:89 jive::decorateWithHereditaryBehaviour(std::unique_ptr) jive_Interpreter.cpp:136 ```...