Iftah

Results 21 comments of Iftah

hi, thank you both for reviewing and for your comments. First, I apologize for not responding earlier, I'm on a family vacation and have even less free time than usual....

As you understood, there are no breaking changes (that I know of) and any existing integration should work just the same with this change. However, there are a couple of...

I made a few changes: 1. changed the code to use the `createRenderer` that @nicoespeon suggested. 2. instead of setting svg.innerHTML to "" and adding a child, I use `replaceChild`...

> However, I'm not sure if the second one behaves as expected. Here's the screenshot I can see: > ![image](https://user-images.githubusercontent.com/1094774/104381751-f8f07f00-54fa-11eb-85b2-a3c7d5a574f9.png) > > The content seems to be cropped on the...

Makes perfect sense, thanks for the reply!

Checked now - no, when I install using CocoaPods there are no problems. CocoaPods generates RXPromise-umbrella.h which includes all three header files.

See related issue https://github.com/DockYard/ember-validations/issues/439

The problem with `{{async-button disabled=isntValid}}` is that it overrides the default async-button `disabled` and takes ONLY the validation into account, so while the async action is running the button is...

Note the data is fetched twice! including the deserialization see https://github.com/reclosedev/requests-cache/issues/437#issue-1034136264