Michael Meyer comments

Results 7 comments of


                                            Michael Meyer

Add spans to Expression (and other types too)

@clarkmcc Needs some more cleanup and tests for the new spans, but the functional part should be done now, all tests are green, at least locally

Add spans to Expression (and other types too)

Yes the `Deref` impl came later, but also I prefer explicitly accessing the field for the `match` instead of relying on deref-magic (sometimes feels like you are just adding and...

Add spans to Expression (and other types too)

That's true, but AFAIK there is nor real overhead between miette and thiserror, so it would be a nice freebee, but definitely not as part of this PR anyway.

Add spans to Expression (and other types too)

@clarkmcc Is there anything still missing? I would love to get this merged so i can pull it in downstream.

Add spans to Expression (and other types too)

I did that so the parser is agnostic as to whether the spans are on or off, if you use `T` instead of `Spanned` when the feature is off, you...

Add spans to Expression (and other types too)

So is there even a point in finishing this @alexsnaps, seeing as your version is more powerful and incompatible

Triggers

Hi @gronke, are you still actively working on this?