IanDelMar

Results 209 comments of IanDelMar

I am in favor of this change. However, this is a breaking change and I suggest to wait for other breaking changes in order to minimize the number of breaking...

The hero slider uses jQuery. I made a PR removing jQuery. See #1840

Have you tried `var popover = new understrap.Popover(exampleEl, options)` or switching from "understrap" to "bootstrap" in rollup.config.js? https://github.com/understrap/understrap/blob/dc36e1cb9f59a9935790023220f1a55d7d1bd073/src/build/rollup.config.js#L40

> should we convert the 'name' variable to 'bootstrap' instead of 'understrap'? Then you can use bootstrap.Popover() in other script files. I see no reason to use 'understrap' here. It's...

> Neither of these really matches the Bootstrap documentation, so they're causing confusion all around. To be fair: the Bootstrap documentation is not written for people bundling Bootstrap like that...

> Or we need to take step back and decide why we're even sanitizing titles to begin with and if this is a common practice. > I don't think that...

>Depends on vulnerable versions of chokidar >node_modules/glob-watcher >gulp >=4.0.0 > Since version 1.0.0 Understrap does not use Gulp anymore. Which version of Understrap do you work with? Are you sure...

> And yes, I am using the latest version of understrap. Do you know a possible solution? Can you please share the content of your package.json file?