Cody
Cody
[Here](https://github.com/googleapis/googleapis/blob/master/google/rpc/error_details.proto) are some generic error protos that are meant to go into that details field.
It looks like that error happens only if the value for the status is [OK](https://github.com/grpc/grpc-go/blob/master/status/status.go#L166).
I'm just blind and missed that somehow. I think that makes sense though. re: sending actual responses instead of empty responses: Is this something we might want to do anyways...
Yea I just thought of it when looking at this. It's not directly tied to this issue.
The test failures seem to be coming from something unrelated to this change: ``` ⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯ FAIL src/__tests__/sentry.test.ts > sentry > interactive > should hit sentry after...
> as you can tell, I've been poking at this PR. Looks like there's an actual failure on windows. I don't have a windows machine, so I'm debugging with CI....
Rebased to try to keep this pr up to date. Still unsure what the issues are in CI.
> > as you can tell, I've been poking at this PR. Looks like there's an actual failure on windows. I don't have a windows machine, so I'm debugging with...
The issue with the windows tests was differences in escaping. Fixed by using JSON.stringify so we get the correct escaping for whatever platform the tests are run on.
@petebacondarwin: I tried to address all your points. Appreciate if you have time to take another look.