ILuffZhe comments

Results 9 comments of


                                            ILuffZhe

[CALCITE-4645] In Elasticsearch adapter, translate a range predicate to a range query(Jacky Yin)

Hi, @yinchuanwang ! Are you still working on this patch? I've disabled testFilterSortDesc() in ElasticsearchAdapterTest.java through https://github.com/apache/calcite/pull/2659, which could be solved in this patch. Please take a look if you...

[CALCITE-7067] Maximum precision of UNSIGNED BIGINT type in MysqlSqlDialect should be 20

@NobiGo @mihaibudiu Do you guys have any other review comments?

[CALCITE-4868] Elasticsearch adapter fails if GROUP BY is followed by ORDER BY

Hi, @NobiGo . I've add some description for this fix, please take a look when you are free.

[CALCITE-4868] Elasticsearch adapter fails if GROUP BY is followed by ORDER BY

I'll reopen this PR after https://github.com/apache/calcite/pull/2657 since those two are highly related.

[CALCITE-5733] Simplify "a = ARRAY[1,2] AND a = ARRAY[2,3]" to "false"

Hi @YasuoStudyJava. The PR's headline should be formatted like "[CALCITE-5733] YOUR JIRA ISSUE SUMMARY", you can take a look at other PRs. Or the recently merged [PR](https://github.com/apache/calcite/pull/3250) is also a...

[CALCITE-5733] Simplify "a = ARRAY[1,2] AND a = ARRAY[2,3]" to "false"

Can you also please add a unit test here? It helps reviewers to understand better.

[CALCITE-5733] Simplify "a = ARRAY[1,2] AND a = ARRAY[2,3]" to "false"

> > > Can you also please add a unit test here? It helps reviewers to understand better. > > > > > > I'll have a try to add...

Make operators and functions in alphabetical order

> If you want this to stay this way you may need to add some kind of linter rule to enforce it. Not sure how easy it is to parse...

Make operators and functions in alphabetical order

Now I get your guys point, I'll see what I can do.