Hind-M

Results 72 comments of Hind-M

Do you have a specific example to test on ?

Is this bug still relevant ? Is it related to the mathematics involved (bad formula) or something else ?

Some general comments: The file `embedded_complex_release.hpp` should be renamed with a `.h` extension. See [Gudhi coding conventions](https://github.com/GUDHI/gudhi-devel/blob/master/.github/code_conventions.md). Is there a reason why `release` is in the name of the file?...

The file `Bitmap_cubical_complex/include/gudhi/Bitmap_cubical_complex/counter.h` doesn't seem to be used anywhere. Should we remove it completely or leave it for maybe a further use?

The output of the benchmark: ``` Cubical complex creation from 100 000 top cells in 1D: 0.014s Cubical complex creation from 100 000 vertices in 1D: 0.019s Cubical complex creation...

IIUC, the construction in C++ is done following the `dimensions` argument given by the user as `[number_of_lines, number_of_columns]`. The fortran ordering is only done in python, before calling the C++...

> Is it supposed to be the product of the elements of `sizes`, instead of something based on `multipliers`? Yes. > We don't reserve for new_indices_to_consider (a bit more than...

GitHub renders the linked notebooks using 'render.githubusercontent.com' domain and integrates the output as a 'nested frame'. But since the included notebook was not rendered separately and represents an entire url,...

Hey @wolfv! I started looking into this, and it seems that we only do some sorting here: https://github.com/mamba-org/mamba/blob/f7a001e24df59ec8e35b45b2e404cd8b049c8eb9/libmamba/src/api/list.cpp#L62-L68 For the other places where we use `records()`, we do a search...

Thanks for the PR. Can you only include in this one the relevant files for the bug fix? The documentation related files should be in another PR (I think reopening...