Tim Klein Nijenhuis

Results 4 comments of Tim Klein Nijenhuis

The MR functionality itself looks good to me. I would, however, prefer to use an utf8 check function like the following, making the utf-8 parsing more readable IMO. It should...

The changes look good. You might want to add a/some 3-byte and 4-byte utf-8 strings to the test cases, also somewhere in the middle of the string to verify the...

The implementation looks good to me. I would, however, suggest to rename 'Abort' to something more explicitly suggesting that this is 'marking the song as broken'. Don't know if I'm...

> > I would, however, suggest to rename 'Abort' to something more explicitly suggesting that this is 'marking the song as broken'. > > Any suggestions? > > 1. Abort...