Congcong Cai

Results 84 comments of Congcong Cai

> When I thought about narrowing in the past, the mechanism I had in mind was to add a new `Flow#localTypes` in addition to `Flow#localFlags`, that would include narrowed types...

By the way, we should not support narrow type for variant like `a.b`. Although TS support this grammar, but it will cause something strange during running. ```typescript class A {}...

@dcodeIO @MaxGraey Could you kindly review this PR and new feature?

@dcodeIO Nonnull check has been merged into type narrow logic. Could you kindly review it?

@dcodeIO Could this feature merge?

@dcodeIO Could you kindly review this PR?

@dcodeIO @MaxGraey. I think add coverage is helpful during feature development. wdyt?

> As such I wonder if hitting the assertion in the first place is a sign that other code does something wrong prior? @dcodeIO Because it used a un-initialized Global...

@dcodeIO What is your opinion about this PR?

> Wouldn't it be more correct to specify `a\b` on Windows, so in `process.argv` one gets a singly-escaped `"a\\b"`? It seems that npm do something in windows. In windows when...