Herman Peeren

Results 12 comments of Herman Peeren

You could do a pull request to this repo to share your FOF-templates with us. I'm working on some Nooku Framework 2.0 templates for EC and will do a PR...

I'm very interested in your FOF-templating attempts and we can also help each other with it! It would be great if more templates would be available for EC. So I...

OK, thanks! * Was also working on **unit-tests** for the php-runtime, as they are missing in the repo now. Or do you already have some tests, that are not in...

> @HermanPeeren we follow the style specified [here](https://github.com/antlr/antlr-php-runtime/blob/master/phpcs.xml.dist). Haha, I cou;ld have seen that... have to look better. Will use that in PHPstorm. Thanks for reviewing, @marcospassos ! Very welcome!

O, perfect, didn't know SplObjectStorage ::blushblush::, but that is exactly it. I'd prefer to wrap that in a ParseTreeProperty-class, so people can easily use it when reading material about ANTLR...

When no value for a node is stored, null is returned. Standard SplObjectStorage::offsetGet() would throw an Exception there.

Reading the above I **propose** to change the deprecation message in both upcoming releases (5.0.2 and 4.4.2) to "Database must be set, this will not be caught anymore in **6.0**."...

Resolved in commit [caa00b2a](https://github.com/nikosdion/joomla_extensions_development/commit/caa00b2a83c5e5b69af6681c1b67afe056e323cf)

Please reread my comments in #81. This issue is superfluous and might come from not fully understanding the power of seperating content and rendering as envisioned in Joomla 4.

Yep, that is the idea: to more easily use extensions in any UI-framework, preferably by not having to change the extensions at all. Just take another Renderer, that can be...