HeinrichAD

Results 30 comments of HeinrichAD

@jcass77 First nice features. But I got one little problem with your changes while I was adding an array support (like in php). You have added that you can you...

I had some time this weekend to look into this problem. My intention was to implement the support for arrays like in php. [Info and example](https://secure.php.net/manual/en/function.parse-ini-file.php) The problem now is...

@rudimeier thanks for the information. I will check this later.

Unfortunately, the example notebook does not work anymore. ![image](https://user-images.githubusercontent.com/5962361/168816407-6d23c958-3960-48cc-8621-e194085abf9a.png) `RuntimeError: Output 0 of BackwardHookFunctionBackward is a view and is being modified inplace. This view was created inside a custom Function...

@JohannesK14 I looked into the source code [1]. In this case it will be the same. So no problems here. [1] https://pytorch.org/vision/main/_modules/torchvision/models/vgg.html#vgg16

Hi @chr5tphr I will provide my feedback here instead of the issue itself. I didn't check the attribution maps in detail, but your code example ([here](https://github.com/chr5tphr/zennit/issues/142#issuecomment-1225669021)) seems to work fine....

Hi @chr5tphr, It makes much more sense now. Thank you for the detailed clarification. If you want I can start a test run if you think it makes sense now....

Hi @chr5tphr, I will try to find some time tomorrow.

Hi @chr5tphr, First thank you for your effort! ### Code In general, the code looks good. It also works as I expected. Only one thing is confussion me: The output...

Thank you for the explanation. In this case the PR gets a ready to go from my side 😄.