Haselnussbomber
Haselnussbomber
Leaving this open then for Dawntrail.
The issue came up, that Dalamuds `SeString.Encode()` doesn't add a null-terminator at the end of its `byte[]` and passing this directly to the `Utf8String.SetString` function (via the `ReadOnlySpan` overload) causes...
Needs another update before it's good to be merged, so it includes https://github.com/aers/FFXIVClientStructs/pull/1463.
Text above the plugin needs to be updated. Still says can be either directory or dll path.
Sorry meant button, not plugin. But you got it. 👍
Oops, forgot about that one. Will fix tomorrow.
clicked the wrong button in vscode ;_; also rebased below
The build is failing because the assembly name is `SRankAssist`, so the name of the folder in D17 needs to match this. It is currently `SRankAssistant`.
I ran into this today and reported it to Asriel in [#dalamud-dev](https://discord.com/channels/581875019861328007/860813266468732938/1300120427313500182). Apparently she already has it fixed locally and will PR it soon. 🙂
This is fixed in 5.2.0 (https://github.com/NotAdam/Lumina/pull/95).