Harald Scheirich

Results 21 comments of Harald Scheirich

One of the ways to get this started is to start small and start using `a` configuration, be that `clang-format` or `editorconfig` pick a configuration that matches the current format...

This is holding us back from using the master, we are adding yaml-cpp via external-project-add, what is the correct solution here ?

There was an interface change, the RangeWidget now _requires_ a `Default` annotation. It seemed more consistent than let the user see the error message that comes up when requested range...

With regards to the default in Qt designer i'd have to check, it all depends on the order and if we're doing the first write from the parameternode to the...

@lassoan i'd have to look if this can be accomplished, right now we can't really discern if a property is "set" it's just a normal python value, it always has...

Thanks, I'll also talk this through with @jcfr and @sjh26 in the new year, i'll be off for the rest of the year. Happy Holidays !

@sjh26 @allemangD Added the last "simple" widgets, changed the requirement for `Default` in the range widget to only require it when the given `FloatRange` does not contain the `[0,0]` range....

@allemangD Did you update slicer ? JC implemented the setRange in https://github.com/commontk/CTK/pull/1158 that;s been merged ? Although maybe Slicer CTK needs to be updated as well

[`qSlicerModulesMenu::setCurrentModule`]( https://github.com/Slicer/Slicer/blob/dad3294757382693cd145163d83a7b0588c68bc0/Base/QTGUI/qSlicerModulesMenu.cxx#L586) gets called from the init function of [`qSlicerSettingsModulesPanel`](https://github.com/Slicer/Slicer/blob/dad3294757382693cd145163d83a7b0588c68bc0/Base/QTGUI/qSlicerSettingsModulesPanel.cxx#L127), this seems to be fairly early during the startup, the call with the `#define` that gets populated from the CMAKE...

I think we can turn this into a tracking issue for the unsupported widgets but there is a difference in the amount of effort it will take to implement some...