HampusMat

Results 11 comments of HampusMat

I'm able to reproduce this. ![2024-01-20-16:32](https://github.com/pwntester/octo.nvim/assets/87620379/931ec699-d430-463f-ac27-b849da02bb2c)

I was able to fix this by inverting the comment start and end lines before writing the thread snippet if the start line is after the end line. ```diff ---...

> Hey, thanks for taking a look! Is there any way I could help? You could possibly help refactoring this function. It is definetly needed

I'm unable to reproduce this at home. Really weird

I have the same problem. I'm using LineageOS 18.1 (Android 11) ![Screenshot_20221116-231958_FastHub-RE](https://user-images.githubusercontent.com/87620379/202307581-dc3caace-15ff-422a-af26-aa4cf1f3e504.png)

Wow i actually somehow haven't thought of this use case. Thank you for bringing it to my attention. I'm not sure that the binding builders should have control over the...

Oh i didn't think about that. It should be possible to make it not take a reference and instead have `CastableFactory` store it in a box. That should solve this...

> First, @HampusMat Thanks for making this library! I think it has a lot of potential. Do you have any timeframe of when this issue is going to be resolved?...

> > First, @HampusMat Thanks for making this library! I think it has a lot of potential. Do you have any timeframe of when this issue is going to be...

Should i add a `to_value` binding builder function that takes a clonable value? It would just call `to_dynamic_value` with `Clone::clone` so it would be kind of redundant but also a...